[Webkit-unassigned] [Bug 265683] AX: add Mac API to get selected text range overlapping static text element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=265683

chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cfleizach at apple.com

--- Comment #4 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 468835
  --> https://bugs.webkit.org/attachment.cgi?id=468835
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468835&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1378
> +    Node* node = m_renderer->node();

auto*

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1381
> +    VisiblePositionRange intersection = WebCore::intersection(selectedVisiblePositionRange, nodeVisibleRange);

i think we can use auto for all of these

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:1281
> +
> +    AXTextMarkerRange range = tree()->selectedTextMarkerRange();

auto

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:1562
> +        NSMutableString* rangeDescription = [NSMutableString stringWithFormat:@"{%lu, %lu}", static_cast<unsigned long>(range.location), static_cast<unsigned long>(range.length)];

NSMutableString *

also i don't think this needs to be mutable

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20231201/267c595e/attachment.htm>