[Webkit-unassigned] [Bug 260997] New: AutoInstall.install_everything is unsafe

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=260997

            Bug ID: 260997
           Summary: AutoInstall.install_everything is unsafe
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: gsnedders at apple.com
                CC: jbedard at apple.com

INTERNALERROR>   File "/Volumes/gsnedders/projects/Safari/OpenSource/Tools/Scripts/libraries/resultsdbpy/.tox/py39/lib/python3.9/site-packages/webkitcorepy/autoinstall.py", line 642, in install_everything
INTERNALERROR>     for packages in cls.packages.values():
INTERNALERROR> RuntimeError: dictionary changed size during iteration

I believe this is caused by:

AutoInstall.register(Package('twisted', Version(21, 2, 0), pypi_name='Twisted', implicit_deps=[
    Package('incremental', Version(21, 3, 0)),
]))

…where the AutoInstaller will AutoInstall twisted, and then recurse into its implicit_deps, and it will then register incremental as it begins to install it—thus mutating the dict being iterated over.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230831/4451d038/attachment-0001.htm>