[Webkit-unassigned] [Bug 260621] AX: aria-controls-with-tabs fails in ITM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=260621

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #21 from Darin Adler <darin at apple.com> ---
Comment on attachment 467467
  --> https://bugs.webkit.org/attachment.cgi?id=467467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467467&action=review

Some post-landing style comments

> Source/WebCore/accessibility/AXObjectCache.cpp:1559
> +    RefPtr oldObject = get(oldNode);

Slight better style:

    if (RefPtr oldObject = get(oldNode))

> Source/WebCore/accessibility/AXObjectCache.cpp:1564
> +        oldFocusedControlledPanel = Accessibility::findAncestor<AccessibilityObject>(*oldObject, false, [] (auto& ancestor) {
> +            return ancestor.roleValue() == AccessibilityRole::TabPanel;
> +        });

Would be nice to share this "find panel" code too, just as we share the "update tab" code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230829/4a46e88a/attachment.htm>