[Webkit-unassigned] [Bug 260750] New: Placate exception check validation in sanitizeRemoteFunctionException.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 25 17:11:54 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=260750

            Bug ID: 260750
           Summary: Placate exception check validation in
                    sanitizeRemoteFunctionException.
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mark.lam at apple.com

sanitizeRemoteFunctionException() can call JSValue::toWTFString() which may throw under certain circumstances.  However, it is only called here if exceptionValue.isPrimitive() i.e. it will never throw.  However, the exception check validator does not know this.  So, we added a `ASSERT(!scope.exception())` to placate it.  

However, if we're forcing exception check validation on a Release build, the ASSERT turns into a no-op.  The fix is to use EXCEPTION_ASSERT here instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230826/05bd13ce/attachment.htm>


More information about the webkit-unassigned mailing list