[Webkit-unassigned] [Bug 260719] New: REGRESSION(267278 at main) [GStreamer] Stable builds broke with missing include and guard

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 25 10:03:51 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=260719

            Bug ID: 260719
           Summary: REGRESSION(267278 at main) [GStreamer] Stable builds
                    broke with missing include and guard
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Media
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: lmoura at igalia.com

Error due to missing include:

In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-19.cpp:5:
../../Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp: In function ‘std::pair<GstAudioFormat, GstAudioLayout> WebCore::convertAudioSampleFormatToGStreamerFormat(const WebCore::AudioSampleFormat&)’:
../../Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp:47:29: error: ‘U8’ is not a member of ‘WebCore::AudioSampleFormat’
   47 |     case AudioSampleFormat::U8:
      |                             ^~
../../Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp:49:29: error: ‘S16’ is not a member of ‘WebCore::AudioSampleFormat’
   49 |     case AudioSampleFormat::S16:
...

And due to missing guard:

../../Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp: In member function ‘void WebCore::PlatformRawAudioData::copyTo(std::span<unsigned char>, WebCore::AudioSampleFormat, size_t, std::optional<long unsigned int>, std::optional<long unsigned int>, long unsigned int)’:
../../Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp:195:25: error: ‘computeBytesPerSample’ was not declared in this scope
  195 |             auto size = computeBytesPerSample(format) * inputBuffer->n_samples;
      |                         ^~~~~~~~~~~~~~~~~~~~~
../../Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp:225:22: error: ‘computeBytesPerSample’ was not declared in this scope
  225 |     auto planeSize = computeBytesPerSample(format) * outputBuffer->n_samples;
      |                      ^~~~~~~~~~~~~~~~~~~~~

Fix incoming.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230825/92b1c1f3/attachment-0001.htm>


More information about the webkit-unassigned mailing list