[Webkit-unassigned] [Bug 260621] AX: aria-controls-with-tabs fails in ITM

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 23 12:07:03 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=260621

--- Comment #6 from Tyler Wilcock <tyler_w at apple.com> ---
(In reply to chris fleizach from comment #3)
> Comment on attachment 467398 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467398&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:1537
> > +void AXObjectCache::handleTabOrControlledTabPanelSelected(Node* node)
> 
> feel like our naming has been moving to
> 
> onTabSelectionChange()
> 
> (that may be enough rather than tabOrControlledTab which is pretty wordy)
The "onFooBar" naming scheme is only for events triggered from the DOM or render tree, so it doesn't fit this case. e.g. onTitleChange, onPopoverTargetToggle

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230823/1ba165df/attachment-0001.htm>


More information about the webkit-unassigned mailing list