[Webkit-unassigned] [Bug 260432] [MQ5] `Scripting` media initial-only value should never match

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 21 15:25:25 PDT 2023


--- Comment #3 from Tim Nguyen (:ntim) <ntim at apple.com> ---
(In reply to Michael[tm] Smith from comment #2)
> I’m trying to figure out if/how the existing
> https://wpt.live/css/mediaqueries/scripting.html needs to be updated to test
> this.
> (In reply to Tim Nguyen (:ntim) from comment #1)
> > It would just be a matter of removing those lines:
> > https://searchfox.org/wubkat/rev/9b7687d4dffc9ecd23f32b4f7c8199f43929d508/
> > Source/WebCore/css/query/MediaQueryFeatures.cpp#610-613
> If I make that change locally and run
> https://wpt.live/css/mediaqueries/scripting.html with my build, the “Check
> that scripting currently matches 'enabled'” test fails.
> But when I test with Firefox, it doesn’t fail.
> So if Firefox is in fact never matching, then it’s doing that without
> failing that test case.
> And so I’m trying to figure out how WebKit can also be made to not match,
> but without failing that “Check that scripting currently matches 'enabled'”
> test case. 
> The
> https://searchfox.org/wubkat/rev/9b7687d4dffc9ecd23f32b4f7c8199f43929d508/
> Source/WebCore/css/query/MediaQueryFeatures.cpp#610-613 change on its own
> doesn’t seem sufficient for achieving that.

I'm surprised that is the case, does your function look like this?

            auto& frame = *context.document.frame();

            if (!frame.script().canExecuteScripts(ReasonForCallingCanExecuteScripts::NotAboutToExecuteScript))
                return MatchingIdentifiers { CSSValueNone };

            return MatchingIdentifiers { CSSValueEnabled };

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230821/86985358/attachment-0001.htm>

More information about the webkit-unassigned mailing list