[Webkit-unassigned] [Bug 260389] AX: Improve smart pointer usage in AXObjectCache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=260389

--- Comment #5 from Joshua Hoffman <jhoffman23 at apple.com> ---
(In reply to Tyler Wilcock from comment #4)
> Comment on attachment 467328 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467328&action=review
> 
> > -    handleAttributeChange(element, attrName, oldValue, newValue);
> > +    handleAttributeChange(protectedElement.get(), attrName, oldValue, newValue);
> 
> I don't think we need to protect this element with a RefPtr if
> !rendererNeedsDeferredUpdate(*element->renderer()) (because otherwise we
> append it to m_deferredAttributeChange which stores it as a WeakPtr). I
> think we only need to protect it if we're going to directly call
> handleAttributeChange with it.

Gotcha—yeah that makes sense. I can move the refptr protection to before the handleAttributeChange call.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230818/3235fd28/attachment.htm>