[Webkit-unassigned] [Bug 260190] AX: aria-labelledby-on-password-input fails in ITM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=260190

--- Comment #5 from Joshua Hoffman <jhoffman23 at apple.com> ---
(In reply to Andres Gonzalez from comment #3)
> (In reply to Joshua Hoffman from comment #2)
> > Created attachment 467283 [details]
> > Patch

> postNotification(dynamicDowncast<AccessibilityObject>(axObject.get()),
> axObject->document(), AXValueChanged);
> +        }
> 
> handleChildrenChanged doesn't seem the right place to add this notification.
> Look at
> 

Placing this codepath inside handleChildrenChanged allows us to update LabelledBy elements regardless of what the change is (since it won't always just be a text change). I collected samples as well and this addition doesn't have an impact on the cost of the method. 

The new test added in the latest patch tests for text changes, to add on to the value change we have covered in the password-input test.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230817/f7753078/attachment.htm>