[Webkit-unassigned] [Bug 260303] New: os_log_set_hook return value is improperly ignored

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 16 14:28:05 PDT 2023


            Bug ID: 260303
           Summary: os_log_set_hook return value is improperly ignored
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: InRadar
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bfulgham at webkit.org

In Bug 253342 we adopted `os_log_set_hook` so that we could relay logging information from the WebContent process to the Network process to add to the logging system.

The documentation for this method says:

 * os_log_set_hook returns the previously registered hook or NULL
 * when this function is first called. As a client, if you register a hook and the
 * return value is not NULL then it is your responsibility to chain the
 * previous hook into the new hook so that both are invoked.

Any previously registered hook is unlikely to be able to interact with `logd`, since we are sandboxed, but perhaps there are other side-effects we want to retain.

To comply with the API design, we should invoke any preregistered hooks before calling our own logic.


You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230816/45c037bd/attachment.htm>

More information about the webkit-unassigned mailing list