[Webkit-unassigned] [Bug 260283] New: Remove LocalResourceHeap and QualifiedResourceHeap

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 16 12:49:52 PDT 2023


            Bug ID: 260283
           Summary: Remove LocalResourceHeap and QualifiedResourceHeap
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sabouhallawa at apple.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

LocalResourceHeap is the only super class of ResourceHeap so it is cleaner to move all the implementation of LocalResourceHeap to ResourceHeap.

All the calls to the add() and get() functions of QualifiedResourceHeap come from RemoteRenderingBackend and RemoteDisplayListRecorder via RemoteResourceCache. These two callers qualify the RenderingResourceIdentifier with m_gpuConnectionToWebProcess->webProcessIdentifier() of the RemoteRenderingBackend.

But RemoteRenderingBackend never changes its m_gpuConnectionToWebProcess since it is defined to be `Ref<GPUConnectionToWebProcess>`. And GPUConnectionToWebProcess never changes its m_webProcessIdentifier since it is defined to be `const WebCore::ProcessIdentifier`. So the resources stored by QualifiedResourceHeap should have the same ProcessIdentifier.

This will make replaying a whole DisplayList in GPU Process be straightforward once the DisplayList items and the resources are transferred from Web Content Process to the GPU Process. The DisplayList::Replayer can be initialized with the decoded DisplayList items and the ResourceHeap of the RemoteResourceCache.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230816/dc85fc33/attachment.htm>

More information about the webkit-unassigned mailing list