[Webkit-unassigned] [Bug 260129] Use 'FrozenArray' for 'thresholds' in IntersectionObserver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=260129

--- Comment #4 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
(In reply to Tim Nguyen (:ntim) from comment #3)
> (In reply to Ahmad Saleem from comment #2)
> > I get following error: 
> > 
> > /Users/ahmadsaleem/Documents/GitHub-Webkit-origin/Webkit/WebKitBuild/Release/
> > DerivedSources/WebCore/JSIntersectionObserver.cpp:297:135: error: 
> >       no member named 'thresholds' in 'WebCore::IntersectionObserver'
> >   ...*thisObject.globalObject(), throwScope, impl.thresholds())));
> > 
> 
> I think this change is the source of your issue:
> 
> > > Source/WebCore/page/IntersectionObserver.h:
> > 
> > Delete: const Vector<double>& thresholds() const { return m_thresholds; }

Indeed! Without doing this and just modifying IDL, I do progress the test. Should I do PR?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230813/58aa8a5e/attachment-0001.htm>