[Webkit-unassigned] [Bug 260129] Use 'FrozenArray' for 'thresholds' in IntersectionObserver

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 13 14:04:33 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=260129

--- Comment #2 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
I get following error: 

/Users/ahmadsaleem/Documents/GitHub-Webkit-origin/Webkit/WebKitBuild/Release/DerivedSources/WebCore/JSIntersectionObserver.cpp:297:135: error: 
      no member named 'thresholds' in 'WebCore::IntersectionObserver'
  ...*thisObject.globalObject(), throwScope, impl.thresholds())));


by doing following changes:

> Source/WebCore/page/IntersectionObserver.idl

Change to: readonly attribute FrozenArray<double> thresholds;

and delete: (double or sequence<double>) threshold = 0.0;

> Source/WebCore/page/IntersectionObserver.h:

Delete: const Vector<double>& thresholds() const { return m_thresholds; }

> Source/WebCore/page/IntersectionObserver.cpp:

Line 425: Changing 'thresholds()' to 'm_thresholds'

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230813/9a4bb560/attachment.htm>


More information about the webkit-unassigned mailing list