[Webkit-unassigned] [Bug 259843] Web Inspector: No search results

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 8 08:20:15 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=259843

--- Comment #4 from Frances <frances_c at cox.net> ---
In FindBanner.js the _inputFieldSearch(event) is not being triggered. (I can see that there is an event listener in the constructor.)

this._inputField.addEventListener("search", this._inputFieldSearch.bind(this), false);

If I add a call to that function (this._inputFieldSearch(event)) in _inputFieldKeyUp(event) the search starts working when typing. 

I am not confident this is the correct solution though.


Frances at MacBook-Air WebKit % git diff
diff --git a/Source/WebInspectorUI/UserInterface/Views/FindBanner.js b/Source/WebInspectorUI/UserInterface/Views/FindBanner.js
index debbf8e67296..df9c4cea0b8f 100644
--- a/Source/WebInspectorUI/UserInterface/Views/FindBanner.js
+++ b/Source/WebInspectorUI/UserInterface/Views/FindBanner.js
@@ -241,6 +241,8 @@ WI.FindBanner = class FindBanner extends WI.NavigationItem
             this._searchBackwards = false;
         else if (event.keyIdentifier === "Enter")
             this._searchKeyPressed = false;
+
+        this._inputFieldSearch(event)
     }

     _inputFieldSearch(event)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230808/2410b836/attachment.htm>


More information about the webkit-unassigned mailing list