[Webkit-unassigned] [Bug 249148] import-w3c-tests should work even without funcsigs in WPT repo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=249148

Sam Sneddon [:gsnedders] <gsnedders at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |237724
           Priority|P2                          |P5

--- Comment #3 from Sam Sneddon [:gsnedders] <gsnedders at apple.com> ---
As I commented in the upstream PR of the revert (https://github.com/web-platform-tests/wpt/pull/37442):

> [ef70ce9](https://github.com/web-platform-tests/wpt/commit/ef70ce9623f50e9e7a89bb713920588cfb1259cf) left `tools/third_party/funcsigs/docs/index.rst` as a symlink to the (non-existent, removed) `tools/third_party/funcsigs/docs/README.rst`, which I believe is the origin of all the problems here.

Given WPT _shouldn't_ have any broken symlinks, this is very low priority, and we're better off fixing this in the near-term by just reverting any change to WPT that introduces and broken symlinks.

The importer bug here would be easy to fix with the Python 3.3+ follow_symlinks argument on `shutil.copyfile(src, dst, *, follow_symlinks=True)`, as we just need to pass `follow_symlinks=False` in copy_tests in test_downloader.py (and pass it though webkitpy.common.system.filesystem), but as long as we support Python 2 this is more effort than is probably justified.

For the record, https://github.com/web-platform-tests/wpt/pull/41292 re-lands the funcsigs drop _with_ the symlink actually removed this time.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=237724
[Bug 237724] Migrate remaining Python 2 scripts
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230802/5ebf5fd3/attachment.htm>