[Webkit-unassigned] [Bug 255425] Remove 'image.isPDFDocumentImage' from ImageQualityController.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=255425

--- Comment #2 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
I think I was wrong.

Looking at the history of ImageQualityController.cpp, I found the bug 121207 added the condition image.isPDFDocumentImage() in ImageQualityController::chooseInterpolationQuality(). I found this statement in the ChangeLog regarding this change:

    * rendering/ImageQualityController.cpp:
    (WebCore::ImageQualityController::shouldPaintAtLowQuality):
    PDFDocumentImage is also interested in/capable of low-quality painting now.

I think this is correct since we usually cache the PDFDocumentImage in a CachedSubImage. And later we draw the ImageBuffer of the CachedSubImage to the GraphicsContext. To draw the ImageBuffer, we have to get a NativeImage from it and then call GraphicsContext::drawNativeImageInternal() which uses ImagePaintingOptions::interpolationQuality() to draw the image and decide whether to use the subImageCache or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230426/9c8b306d/attachment.htm>