[Webkit-unassigned] [Bug 255962] New: run-minibrowser: improve how extra parameters are passed to the minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=255962

            Bug ID: 255962
           Summary: run-minibrowser: improve how extra parameters are
                    passed to the minibrowser
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: clopez at igalia.com
                CC: bugs-noreply at webkitgtk.org, philn at igalia.com

Currently the script run-minibrowser passed to the minibrowser any extra parameter not recognized by the script, which in theory is fine but in some cases it causes issues.

For example, on WPE, is not possible to properly execute Cog with another platform plugins and a custom URL.

Example 1)

$ Tools/Scripts/run-minibrowser --wpe -P drm https://spyber.com

This ends executing "cog -P https://spyber.com drm" because the script picks the first parameter without a dash as the URL (so it thinks "drm" is the URL)


$ Tools/Scripts/run-minibrowser --wpe --platform=drm https://spyber.com

This gives error because --platform is a parameter that the script wants to parse itself instead of passing it to cog (it checks for platform in [wpe, gtk, mac, etc]))


The only possible way of doing it is inverting the order

$ Tools/Scripts/run-minibrowser --wpe https://spyber.com -P drm 


Which is far from evident unless you know the issue.


We can improve this by allowing to specify something like this:

Tools/Scripts/run-minibrowser --wpe --minibrowser-args="-P drm" https://spyber.com


That way there is no confusion and we can even pass to cog parameters like --minibrowser-args='--help' so we can get Cog to print its own help instead of getting the help from the script run-minibrowser

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230425/9d71f7c2/attachment.htm>