[Webkit-unassigned] [Bug 255761] Crash in WebCore::BackgroundPainter::calculateBackgroundImageGeometry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 20 20:33:47 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=255761

--- Comment #3 from Michael Catanzaro <mcatanzaro at redhat.com> ---
This naive patch avoids the crash (but I doubt it's the correct solution):

diff --git a/Source/WebCore/rendering/RenderLayerBacking.cpp b/Source/WebCore/rendering/RenderLayerBacking.cpp
index d182f008bfdd..3628348a4d60 100644
--- a/Source/WebCore/rendering/RenderLayerBacking.cpp
+++ b/Source/WebCore/rendering/RenderLayerBacking.cpp
@@ -2730,6 +2730,9 @@ void RenderLayerBacking::updateDirectlyCompositedBackgroundImage(PaintedContents
         return;
     }

+    if (!renderBox())
+        return;
+
     auto backgroundBox = LayoutRect { backgroundBoxForSimpleContainerPainting() };
     // FIXME: Absolute paint location is required here.
     auto geometry = BackgroundPainter::calculateBackgroundImageGeometry(*renderBox(), renderBox(), style.backgroundLayers(), { }, backgroundBox);

> FYI Cocoa platforms don’t use updateDirectlyCompositedBackgroundImage().

Uh, OK, let's move to WebKitGTK component then.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230421/d14efd98/attachment-0001.htm>


More information about the webkit-unassigned mailing list