[Webkit-unassigned] [Bug 255678] [GStreamer] GstGLContext use-after-free

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=255678

--- Comment #3 from Michael Catanzaro <mcatanzaro at redhat.com> ---
So my opinion is we should give up on calling terminateEGLDisplay() due to the long history of bugs associated with attempting to do this (bug #145832, bug #174789, bug #176490, and surely more), and because it's not necessary unless there are global resource leaks in low-quality graphics drivers, which should be fixed in affected drivers rather than worked around in WebKit.

I also understand that would be inconvenient for certain downstream purposes, so... I guess let's try using std::atexit to destroy the shared display instead of leaving it up to chance; maybe that will work? Our current code expects exit handlers manually registered using std::atexit to always execute before static variable destructors, but I suppose that's a bad assumption. Also, PlatformDisplay is used on Windows now, where order of destruction of static variables is undefined, so it's unsafe regardless. (Only Linux-specific code is allowed to put types that are not trivially-destructible into static variables.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230419/18eaa921/attachment.htm>