[Webkit-unassigned] [Bug 255425] New: Remove 'image.isPDFDocumentImage' from ImageQualityController.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=255425

            Bug ID: 255425
           Summary: Remove 'image.isPDFDocumentImage' from
                    ImageQualityController.cpp
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Images
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: sabouhallawa at apple.com, simon.fraser at apple.com

Hi Team,

While trying to do bug 115158, in the PR 5111, Said mentioned following:

_______________________

I think the image interpolation quality has nothing to do with the PDFDocumentImage. So I think we either need to remove the condition image.isPDFDocumentImage() or we fix the comment.

and

Yes. Please remove image.isPDFDocumentImage() from this if-statement since PDFDocumentImage::draw() does not call the ImagePaintingOptions::interpolationQuality().

________________________

I didn't get rid of it that time but I think I can do this in this separate bug.

Still present - https://github.com/Ahmad-S792/WebKit/blob/main/Source/WebCore/rendering/ImageQualityController.cpp#L119

Just wanted to raise and also get input again whether it is still good to go.

Happy to do PR.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230413/c4ce8324/attachment-0001.htm>