[Webkit-unassigned] [Bug 255047] New: AX: AccessibilityRenderObject::addRemoteSVGChildren() should protect the created SVG object with a RefPtr
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 5 13:25:15 PDT 2023
https://bugs.webkit.org/show_bug.cgi?id=255047
Bug ID: 255047
Summary: AX: AccessibilityRenderObject::addRemoteSVGChildren()
should protect the created SVG object with a RefPtr
Product: WebKit
Version: WebKit Nightly Build
Hardware: All
OS: All
Status: NEW
Severity: Normal
Priority: P2
Component: Accessibility
Assignee: webkit-unassigned at lists.webkit.org
Reporter: tyler_w at apple.com
CC: andresg_22 at apple.com,
webkit-bug-importer at group.apple.com
Per https://github.com/WebKit/WebKit/wiki/Smart-Pointer-Usage-Guidelines:
> Every object passed to a non-trivial function as an argument (including "this" pointer) should be stored as a Ref, RefPtr, CheckedRef, or CheckedPtr in the caller’s local scope
Let's bring this function inline with this guidance since AccessibilityObject::addChild is not trivial.
This RefPtr will be free in the common case that there is no remote SVG root object to add.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230405/df9a589f/attachment-0001.htm>
More information about the webkit-unassigned
mailing list