[Webkit-unassigned] [Bug 254914] [EWS][git-webkit] Tools get confused when PR is created from a branch named “main”

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 3 06:12:13 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=254914

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
(In reply to Sam Sneddon [:gsnedders] from comment #1)
> It shouldn't be too hard to add a warning/error/prompt in this case, I don't
> think.
> 
> Does `git webkit commit` fail, or just `git webkit pr`?

I have double checked now:

 1. git webkit commit -> works fine

 2. git webkit pfr -> gives the message
    “'main' is not a pull request branch, enter issue URL or title of new issue:”

    Entering an issue number results in a new local branch being
    created, but the PR opened has only “???” in its title and
    summary. You can see that in this test PR that I have created
    to demonstrate this: https://github.com/WebKit/WebKit/pull/12316

I think the latter is what happened in PR 11913 which I linked in the
bug description. Then the issue with the EWS is (I think) that they
manually pushed to the “main” branch in their personal clone of the
repository, created the PR from GitHub with the appropriate commit
log formatting, and then the builders gave the error we can see in
the builder links above.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230403/c59658c0/attachment-0001.htm>


More information about the webkit-unassigned mailing list