[Webkit-unassigned] [Bug 254914] New: [EWS][git-webkit] Tools get confused when PR is created from a branch named “main”
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 3 05:26:50 PDT 2023
https://bugs.webkit.org/show_bug.cgi?id=254914
Bug ID: 254914
Summary: [EWS][git-webkit] Tools get confused when PR is
created from a branch named “main”
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Tools / Tests
Assignee: webkit-unassigned at lists.webkit.org
Reporter: aperez at igalia.com
Steps to reproduce:
1. Setup the WebKit repository for contribution.
2. Add a commit directly on your local clone of the “main” branch.
3. Try submitting a patch with “git webkit commit && git webkit pfr” -- fun things happen.
4. Manually format the commit log and create the PR anyway -- EWS builds fail, e.g:
https://ews-build.webkit.org/#/builders/5/builds/2675
https://ews-build.webkit.org/#/builders/2/builds/2514
This happened in https://github.com/WebKit/WebKit/pull/11913 ️
Not sure if we want to enforce^W encourage always using a branch with
a name different from “main” or to allow it. In the first case it would be
better to get a warning from the tools, in the latter we would need to fix
the tools to not trip on “main”. IMO both solutions would be okay, I have
no strong opinion for one or the other.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230403/68807f49/attachment.htm>
More information about the webkit-unassigned
mailing list