[Webkit-unassigned] [Bug 245576] [SOUP] Should not hit internal error preconnecting when preconnect is disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=245576

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 462600
  --> https://bugs.webkit.org/attachment.cgi?id=462600
Add ENABLE(SERVER_PRECONNECT) guards

View in context: https://bugs.webkit.org/attachment.cgi?id=462600&action=review

> Source/WebCore/html/HTMLAnchorElement.cpp:542
> +#if !ENABLE(SERVER_PRECONNECT)
> +    return;
> +#endif

It would be better to add the guard around the block below. But I wonder if it would be better to check linkPreconnectEnabled in settings instead. Alex? Chris?

> Source/WebCore/loader/LinkLoader.cpp:214
> +#if !ENABLE(SERVER_PRECONNECT)
> +    return;
> +#endif

Are you sure you need this one? If server preconnect is disabled then params.relAttribute.isLinkPreconnect should be false below, so it will return early in any case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220927/2d36043e/attachment.htm>