[Webkit-unassigned] [Bug 115689] Simplify FrameLoaderStateMachine and FrameLoader::transitionToCommitted().

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 23 18:07:23 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=115689

--- Comment #5 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
I tried to land this via PR:

https://github.com/WebKit/WebKit/pull/4364

but I was not successful compared to Don and had following build failures:

./loader/FrameLoader.cpp:4264:59: error: no member named 'DisplayingInitialEmptyDocumentPostCommit' in 'WebCore::FrameLoaderStateMachine'; did you mean 'DisplayingInitialEmptyDocument'?

Further based on the result from Don, there are crashes and blood bath with this change and there might be more to fix than just doing merge.

>From the benefits perspective, I think @rniwa can pitch in better but if there is a need to keep this bug open or invest in this simplification, we can. Else we can close this and move on.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220924/49dac1ea/attachment.htm>


More information about the webkit-unassigned mailing list