[Webkit-unassigned] [Bug 245356] Make narrowPrecisionToFloat() use clampTo<float>() instead of static_cast

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 21 03:53:30 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=245356

--- Comment #1 from Nikolas Zimmermann <zimmermann at kde.org> ---
Seems like a valid change. Thanks to SFINAE clampTo<> generates fast code - boils down to a static_cast for doubles within "float" range, plus some additional branching/testing overhead -- hopefully small enough. I think it's fine -- did you try running full layout tests to see if we have differences anywhere due to this?

Do you have a testcase which gets fixed after your patch? (Blink mentions some svg/text/ test + large zoom factor). That would be ideal.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220921/5e567720/attachment-0001.htm>


More information about the webkit-unassigned mailing list