[Webkit-unassigned] [Bug 245424] New: Rename unclear usage of Color::isValid() to explicit isCurrentColor()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 20 06:50:46 PDT 2022
https://bugs.webkit.org/show_bug.cgi?id=245424
Bug ID: 245424
Summary: Rename unclear usage of Color::isValid() to explicit
isCurrentColor()
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: WebCore Misc.
Assignee: webkit-unassigned at lists.webkit.org
Reporter: m_dubet at apple.com
Due to the representation of "current color" as "invalid color" in WebCore, they are two functionally equivalent functions is the codebase :
- Color::isValid()
- RenderStyle::isCurrentColor(Color) (which is implemented as "return !color.isValid()).
The second one makes the intention of the check clearer and should be preferred.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220920/add5dba9/attachment.htm>
More information about the webkit-unassigned
mailing list