[Webkit-unassigned] [Bug 118818] Account for zoom when computing SVG font size

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 20 02:50:55 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=118818

--- Comment #3 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
Just to document my PR attempt:

https://github.com/WebKit/WebKit/pull/4011

____________

1) ScalingFactor can go below '1' so restricting it at "1" is not ideal. Someone need to think about on how to add this to the code and manage it.
2) iOS-wk2 has "text-size-adjst" in svg.css as "UA" stylesheet, so "font-small-enlarged-minimum-larger-expected.svg" does not work and have to add "platform" specific expectations.
3) font-small-enlarged-minimum-larger-expected.svg has "Script" in it, while it can be hardcoded to "80" to work perfectly fine except (2).
4) Due to LBSE work, GeometricPrecision work is now handled differently.

___________

Further, this patch had issue, which was resolved further in Comment 02 patch, so when merging, you had to account for both.

I am waiting on final response but if I am not able to tackle it. I will close my PR 4011 and then leave it to someone else to finish it.

Just wanted to summarise the work here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220920/c8ca0b51/attachment.htm>


More information about the webkit-unassigned mailing list