[Webkit-unassigned] [Bug 245135] New: Holepunch missing after video source change

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=245135

            Bug ID: 245135
           Summary: Holepunch missing after video source change
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WPE WebKit
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: olivier.blin at softathome.com
                CC: aperez at igalia.com, bugs-noreply at webkitgtk.org,
                    cgarcia at igalia.com, Hironori.Fujii at sony.com,
                    loic.yhuel at softathome.com, magomez at igalia.com,
                    zdobersek at igalia.com

Created attachment 462314

  --> https://bugs.webkit.org/attachment.cgi?id=462314&action=review

Test case to reproduce the missing holepunch after changing video source

Since r295749 (251754 at main), the holepunch feature is broken (missing) after changing the video source.
See https://bugs.webkit.org/show_bug.cgi?id=240283 for the crash fix which causes this regression.

This bug can be seen with YouTube TV, just after skipping an ad.

The holepunch contents layer is reset to NULL after changing the source, which causes the holepunch buffer not to be rendered anymore.

The new content layer from the new MediaPlayer is set from TextureMapperPlatformLayerProxyGL::activateOnCompositingThread(), but after that, TextureMapperPlatformLayerProxyGL::invalidate() is called to invalidate the old content layer from the old MediaPlayer.
This sets the content layer to NULL in the target layer, and this disables the new content layer.

This can be reproduced on a WPE build with USE_GSTREAMER_HOLEPUNCH=ON and the attached test page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220913/26af39a2/attachment.htm>