[Webkit-unassigned] [Bug 245108] New: Add type for PlatformMouseEvent modifier flags

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=245108

            Bug ID: 245108
           Summary: Add type for PlatformMouseEvent modifier flags
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: abigail_fox at apple.com, achristensen at apple.com,
                    sam at webkit.org, thorton at apple.com
        Depends on: 47651, 171297

Add type for PlatformMouseEvent modifier flags.

Only Mac and Windows actually use modifier flags on the PlatformMouseEvent object and AFAICT:
- The `unsigned` type is not big enough for either the `NSEventModifierFlags` type on macOS or the `WPARAM` type on Windows.
- The instance variable is never used on iOS/tvOS/watchOS platforms.
- The lack of type may have caused conversion to the wrong enum value in the fix for Bug 171297 (188192 at main).

Need to check with some experts what MacCatalyst should do in these cases.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=47651
[Bug 47651] PlatformMouseEvents need to contain modifier flags
https://bugs.webkit.org/show_bug.cgi?id=171297
[Bug 171297] REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220913/6794ddc8/attachment-0001.htm>