[Webkit-unassigned] [Bug 245093] New: [ANGLE] Build broken when targeting Android

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=245093

            Bug ID: 245093
           Summary: [ANGLE] Build broken when targeting Android
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com

When targeting Android building ANGLE fails due to a conditional inclusion
in “Source/ThirdParty/ANGLE/src/compiler/translator/tree_util/BuiltIn.h”:

  #if defined(ANDROID)
  #    include "BuiltIn_ESSL_autogen.h"
  #else
  #    include "BuiltIn_complete_autogen.h"
  #endif

This means that when targeting Android currently this header is chosing to
include BuilIn_ESSL_autogen.h, but then SymbolTable_autogen.cpp gets built,
which needs symbols which are in BuiltIn_complete_autogen.h instead!

Turns out that in “Source/ThirdParty/ANGLE/CMakeLists.txt” the contents of
the variable ${angle_translator_glsl_symbol_table_sources} always get added
to the build, while according to the GN build definitions:

  # From Source/ThirdParty/ANGLE/gni/angle.gni:
  angle_enable_gl_desktop = !is_android && !is_ios

  # Same file, later on:
  angle_enable_desktop_glsl = angle_enable_gl_desktop

  # Finally, in BUILD.gn
  if (angle_enable_desktop_glsl) {
      sources += angle_translator_glsl_symbol_table_sources
  } else {
      sources += angle_translator_essl_symbol_table_sources                                                                                                                                                                                    
  }

This means that the CMake build should follow the same approach and pick one of
${angle_translator_glsl_symbol_table_sources} or ${angle_translator_ess_symbol_table_sources}
accordingly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220912/f915bd23/attachment-0001.htm>