[Webkit-unassigned] [Bug 245019] New: Use 'break' instead of 'continue' in a 'do { } while (false)' loop

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=245019

            Bug ID: 245019
           Summary: Use 'break' instead of 'continue' in a 'do { } while
                    (false)' loop
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Media
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: eric.carlson at apple.com

Use 'break' instead of 'continue' in a 'do { } while (false)' loop.

In Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp:

```
bool CDMSessionClearKey::update(Uint8Array* rawKeysData, RefPtr<Uint8Array>& nextMessage, unsigned short& errorCode, uint32_t& systemCode)
{
    [...]

    do {
        auto rawKeysString = String::fromUTF8(rawKeysData->data(), rawKeysData->length());
        if (rawKeysString.isEmpty())  {
            LOG(Media, "CDMSessionClearKey::update(%p) - failed: empty message", this);
            continue;
        }
        [...]
    } while (false);

    [...]
}
```

Found by CodeQL.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220910/a1c8ea1c/attachment.htm>