[Webkit-unassigned] [Bug 26804] Line Feed in input value attribute moves text out of button

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26804

--- Comment #5 from Vitor Roriz <vitor.roriz at apple.com> ---
More specifically:

RenderFlexibleBox::layoutFlexItems calls layoutAndPlaceChildren which updates RenderFlexibleBox height with:

> setLogicalHeight(std::max(logicalHeight(), crossAxisOffset + flowAwareBorderAfter() + flowAwarePaddingAfter() +


However, in the end layoutFlexItems updates logicalHeight for RenderFlexibleBox again with updateLogicalHeight(RenderFlexibleBox.cpp:1216).

updateLogicalHeight calls RenderBox::computeLogicalHeight which sets logical height to a cached value, which does not account for the multiple lines. The following comment is relevant:

> RenderBox.cpp:3221:
> // The parent box is flexing us, so it has increased or decreased our height.  We have to
> // grab our cached flexible height.

This happens exactly at RenderBox.cpp:3259 where we calculate hightResult = constrainLogicalHeightByMinMax(heightResult, intrinsicHeight). Being intrinsicHeight the height taking in consideration the children and highResult the cached height.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220907/3f52f3bd/attachment-0001.htm>