[Webkit-unassigned] [Bug 244695] New: AX: AXObjectCache::handleChildrenChanged should not dirty the whole tree's children

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 1 17:56:05 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=244695

            Bug ID: 244695
           Summary: AX: AXObjectCache::handleChildrenChanged should not
                    dirty the whole tree's children
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Accessibility
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: tyler_w at apple.com
                CC: andresg_22 at apple.com,
                    webkit-bug-importer at group.apple.com

AXObjectCache::handleChildrenChanged does this:


bool shouldUpdateParent = true;
for (auto* parent = &object; parent; parent = parent->parentObjectIfExists()) {
    if (shouldUpdateParent)
        parent->setNeedsToUpdateChildren();

    ...
}

Which seems wasteful. We should probably not dirty the entire ancestry of every changed object when it's just the children of target object that have changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220902/dbe7b14b/attachment.htm>


More information about the webkit-unassigned mailing list