[Webkit-unassigned] [Bug 244128] Add experimental feature to disable Bitmap image animations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=244128

--- Comment #46 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 462061
  --> https://bugs.webkit.org/attachment.cgi?id=462061
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462061&action=review

>> Source/WebCore/page/Page.cpp:4035
>> +    m_allowsImageAnimations = shouldAnimate;
> 
> Why do we have to options to enable the animations? You even check the settings() member but you set the Page member. I think we can rely on the Settings only:
> 
>     if (settings().imageAnimationEnabled())
>         return;
> 
>     settings().setImageAnimationEnabled(true);
> 
> Another approach is to add a webcoreOnChange to your setting. See CoreMathMLEnabled in WebPreferencesExperimental.yaml as an example.

A better example to follow for webcoreOnChange may be ScrollingPerformanceTestingEnabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220901/1a2de14a/attachment.htm>