[Webkit-unassigned] [Bug 244128] Add experimental feature to disable Bitmap image animations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 1 10:29:25 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=244128

--- Comment #42 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
(In reply to Joshua Hoffman from comment #41)
> (In reply to Said Abou-Hallawa from comment #40)
> 
> > > +This patch adds a new experimental AX preference, which when disabled, prevents BitmapImage animations. Additionally, we provide new interfaces to control animations at the page and individual image level.
> > 
> > re: Additionally, we provide new interfaces to control animations at the
> > page and individual image level.
> > 
> > 1) What is the use case of controlling the animation on individual image?
> > 2) What is the interface for using this feature? In this patch I see
> > resumeAnimation()/pauseAnimation() are used by Internals only. Is the plan
> > to use it for testing only?
> > 3) What should happen if two HTMLImageElements are accessing the same image
> Users who have animations disabled globally may want to see a particular
> animation that contains important content, without having to resume all
> animations. Several sites & social media platforms implement this type of
> control in their own settings already.
> 
> A context menu item to resume/pause these animations would provide users an
> interface to control this.
> 

I am not aware there's something like this in the web. Can you please guide me to the specs' link and where I can see this feature in Chrome and FireFox or sites & social media platforms?

If there is no specs' for this, then we need to file a GitHub issue for it. We have to provide an interface that all browsers agree on.

But if this is the plan, how can this be implemented by your patch given the only interface is through Internals?

> For #3, see below. 
>  
> > <img id="image1" src="animated_image.gif">
> > <img id="image2" src="animated_image.gif">
> > <script>
> >     internals.resumeImageAnimation(image1);
> > </script>
> > 
> > Do you expect the animation will be resumed in both elements (image1  and
> > image2) or only the first one (image1)?
> 
> If it's the same source, both images will resume animation. This assumes a
> user who wants to see a particular image animate will want to see that image
> animate in all occurrences.

I do not think this is correct. This flag should be set per HTMLImageElement as the Internal API says. I think having it per CachedImage (or per URL as you implemented it) is a technical details that the user should not deal with. 

Maybe I am wrong and this is why a specs' link or a GitHub issue can answer this question clearly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220901/3cfd5648/attachment-0001.htm>


More information about the webkit-unassigned mailing list