[Webkit-unassigned] [Bug 247266] New: [css-grid] Implicit grid may need to be expanded when grid-auto-flow != masonry axis

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=247266

            Bug ID: 247266
           Summary: [css-grid] Implicit grid may need to be expanded when
                    grid-auto-flow  != masonry axis
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sgill26 at apple.com

Created attachment 463324

  --> https://bugs.webkit.org/attachment.cgi?id=463324&action=review

Testcase

If grid-auto-flow != masonry axis, then there may be an issue fitting certain items into the grid. The standard grid placement algorithm will increase the size of the grid in the axis opposite of grid-auto-flow direction to accommodate any items that have a large span. The same logic needs to be applied when grid-auto-flow does not match the masonry axis. For example:

grid-auto-flow: row
masonry: column

In the above scenario if an item's row span is larger than the grid, the item will overflow and trigger the debug assert in GridMasonryLayout::updateRunningPositions (note release builds will clamp the size of the span so that it will fit into the grid). We should increase the size of the implicit grid in these types of scenarios. 

Interestingly, the expected behavior occurs if you change style="grid-row: 1 / span 8" to style="grid-row: 2 / span 8", so we probably just need to match that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221031/52333540/attachment-0001.htm>