[Webkit-unassigned] [Bug 247232] New: additionalOutlineSize is always zero in ShadowData[cpp|h]

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 29 13:33:25 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=247232

            Bug ID: 247232
           Summary: additionalOutlineSize is always zero in
                    ShadowData[cpp|h]
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Hi Team,

This is bug created for removing the "additionalOutlineSize" because it is always zerp.

Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=180370

It does not have any test case and would make the code cleaner:

https://github.com/WebKit/WebKit/blob/1104571ccd3419d753fa3cb57f8f04300466a9f3/Source/WebCore/rendering/style/ShadowData.h#L90

https://github.com/WebKit/WebKit/blob/1104571ccd3419d753fa3cb57f8f04300466a9f3/Source/WebCore/rendering/style/ShadowData.cpp#L81

https://github.com/WebKit/WebKit/blob/1104571ccd3419d753fa3cb57f8f04300466a9f3/Source/WebCore/rendering/style/ShadowData.cpp#L84

https://github.com/WebKit/WebKit/blob/1104571ccd3419d753fa3cb57f8f04300466a9f3/Source/WebCore/rendering/style/ShadowData.cpp#L84

and other instances.

___

There are no usage of it outside above these two files while checking via Webkit GitHub search.

I am creating this bug for the PR purposes but if it serves any other purpose, happy to close it out later.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221029/24edf694/attachment.htm>


More information about the webkit-unassigned mailing list