[Webkit-unassigned] [Bug 210935] Resize cursor doesn't show if there's text under the resize control
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Oct 29 11:24:43 PDT 2022
https://bugs.webkit.org/show_bug.cgi?id=210935
Ahmad Saleem <ahmad.saleem792 at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ahmad.saleem792 at gmail.com
--- Comment #1 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
It seems to be fixed with following Commit:
https://src.chromium.org/viewvc/blink?view=revision&revision=160554
It did changes here:
https://github.com/WebKit/WebKit/blob/9856bc8b756610ac4e3a4a2c480e6332f50e0cd7/Source/WebCore/page/EventHandler.cpp#L1544
___
Webkit (current):
inResizer = layerRenderer.layer()->isPointInResizeControl(roundedIntPoint(result.localPoint()));
Chrome Patch:
inResizer = layer->isPointInResizeControl(result.roundedPointInMainFrame(), ResizerForPointer);
*** Need to be changed ***
inResizer = layerRenderer.layer()->isPointInResizeControl(roundedIntPoint(result.roundedPointInMainFrame(), localPoint);
___
If someone can confirm the approach, I am happy to do PR. Only problem / build error might be that it could only accept 1 argument but now we are providing it two. For that, if we can do:
auto joined = roundedIntPoint(result.roundedPointInMainFrame(), localPoint);
and then pass on single argument.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221029/a7b1ed14/attachment.htm>
More information about the webkit-unassigned
mailing list