[Webkit-unassigned] [Bug 247168] New: XPCServiceInitializer should process "disable-jit" before "enable-captive-portal-mode".

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=247168

            Bug ID: 247168
           Summary: XPCServiceInitializer should process "disable-jit"
                    before "enable-captive-portal-mode".
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mark.lam at apple.com
                CC: kkinnunen at apple.com

The reason is because "disable-jit" calls JSC::ExecutableAllocator::setJITEnabled(), which should be done before calling JSC::Options::initialize().  The processing of "enable-captive-portal-mode" in XPCServiceInitializer does itself call JSC::ExecutableAllocator::setJITEnabled() before calling JSC::Options::initialize().  Hence, if we process "disable-jit" case afterwards, it will have no effect because JSC::Options::initialize() has already been called.

In practice, this doesn't matter because both the "disable-jit" and "enable-captive-portal-mode" cases disables the JIT.  However, just so the code doesn't erroneously suggest that it's ok to call JSC::ExecutableAllocator::setJITEnabled() after calling JSC::Options::initialize(), let's fix the order.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221028/737cb06c/attachment.htm>