[Webkit-unassigned] [Bug 247089] [GTK] UI process crash when opening video settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=247089

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexm at gnome.org

--- Comment #3 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Carlos Garcia Campos from comment #2)
> I think we are still in time to try different approach in the new API.

Yes.

> I would just stop using GdkEvent in context and popup menu signals. We can add
> a custom boxed type that can be shared with wpe and provide the info we want
> there.

Hmm, that could work, and would resolve a separate problem with the WPE API as well... although we'd need to agree on what info this type would need to convey. Epiphany only looks at gdk_event_get_type() to check for GDK_BUTTON_PRESS, then in that case, it uses gdk_event_get_modifier_state() and passes the GdkModifierType along to WebExtensions to decide what to do with it. That code is probably new, which would explain why we didn't notice before now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221027/1c65293d/attachment-0001.htm>