[Webkit-unassigned] [Bug 246957] New: [build.webkit.org] BuildAndTestAllButJSCFactory must forward parameters correctly to BuildAndTestFactory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=246957

            Bug ID: 246957
           Summary: [build.webkit.org] BuildAndTestAllButJSCFactory must
                    forward parameters correctly to BuildAndTestFactory
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: lmoura at igalia.com

The initial version of https://github.com/WebKit/WebKit/pull/5710 added `additionalArguments` to a bunch of bots, including GTK-Linux-64-bit-Release-GTK4-Tests, which uses the BuildAndTestAllButJSCFactory, a subclass of BuildAndTestFactory.

This raised a failure in the build-webkit-org unittests with the extra steps when `triggers` is non-null added to the test output.

Turns out that BuildAndTestAllButJSCFactory wasn't forwarding the `triggers` parameter correctly to its parent class.

Originally `additionalArguments` was empty, and the test worked fine.

Patch incoming.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221024/da4d11b6/attachment.htm>