[Webkit-unassigned] [Bug 112655] text-combine's text-shadow is not correctly positioned.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112655

Ahmad Saleem <ahmad.saleem792 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ahmad.saleem792 at gmail.com

--- Comment #6 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
It is still broken for combined text based on the "reproduced html content" and I think we need to add "const TextBoxPainter& shouldRotate" in here:

https://github.com/WebKit/WebKit/blob/42fe4a9f7ac5d2ecb5bd81e40ff9524f445e22ef/Source/WebCore/rendering/TextPainter.cpp#L132

and then update this:

https://github.com/WebKit/WebKit/blob/42fe4a9f7ac5d2ecb5bd81e40ff9524f445e22ef/Source/WebCore/rendering/TextPainter.cpp#L208

by adding (!shouldRotate) as condition.

I am not sure whether we need to update other two places or not, which the patch was trying to modify.

If someone confirm that this is right approach, I am happy to do PR with giving credit to Yuki. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221022/e6f0ef88/attachment-0001.htm>