[Webkit-unassigned] [Bug 246760] New: [WPE][GTK] All post-commit buildbots should build with --no-fatal-warnings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 19 12:33:43 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=246760

            Bug ID: 246760
           Summary: [WPE][GTK] All post-commit buildbots should build with
                    --no-fatal-warnings
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKitGTK
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at gnome.org
                CC: bugs-noreply at webkitgtk.org, lmoura at igalia.com

I intend to enable DEVELOPER_MODE_FATAL_WARNINGS by default to finally fix bug #155047, since I've been spending way too much time fighting build warnings instead of doing more interesting work, and really need the EWS bots to enforce fatal warnings. But we never want to lose test results to a silly build warning: that would be brutal punishment for somebody introducing a new warning. So for this to work, we need post-commit buildbots (but not EWS) to use build-webkit --no-fatal-warnings. Post-commit bots that don't use build-webkit should use the -DDEVELOPER_MODE_FATAL_WARNINGS=OFF CMake option. 

I'm not sure the best way to do this. We could add additional arguments to every bot in Tools/CISupport/build-webkit-org/config.json, but that would need to be repeated for every single bot. Maybe there is another way? Don't want to change build-webkit because fatal warnings should be default in developer mode. (The name of the option DEVELOPER_MODE_FATAL_WARNINGS doesn't make much sense otherwise.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221019/6b18ff31/attachment.htm>


More information about the webkit-unassigned mailing list