[Webkit-unassigned] [Bug 246737] AX: Make animated image experimental feature respect preferences

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=246737

Tyler Wilcock <tyler_w at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tyler_w at apple.com

--- Comment #4 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 463087
  --> https://bugs.webkit.org/attachment.cgi?id=463087
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463087&action=review

> Source/WebCore/page/SettingsBase.cpp:-491
> -void SettingsBase::setImageAnimationControlEnabledChanged()
> -{
> -    if (m_page && !m_page->settings().imageAnimationControlEnabled())
> -        m_page->setImageAnimationEnabled(true);
> -}

I'm not sure if we can remove this until we remove the experimental flag entirely. This code is important because it turns animations back on if the feature flag is disabled so users aren't stuck with a page of disabled animations.

> Source/WebCore/testing/Internals.cpp:1055
> -    if (auto* page = contextDocument() ? contextDocument()->page() : nullptr) {
> -        if (page->settings().imageAnimationControlEnabled())
> -            page->setImageAnimationEnabled(enabled);
> -    }
> +    if (auto* page = contextDocument() ? contextDocument()->page() : nullptr)
> +        page->setImageAnimationEnabled(enabled);

Why remove:

if (page->settings().imageAnimationControlEnabled())

here? Is it no longer necessary?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1129
> +    _page->process().updateAnimatedImagesState();

Where is updateAnimatedImagesState defined? I couldn't find it in this patch or in WebKit `main`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221019/394438a2/attachment-0001.htm>