[Webkit-unassigned] [Bug 246595] New: Change CSSValue types to have immutable value semantics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=246595

            Bug ID: 246595
           Summary: Change CSSValue types to have immutable value
                    semantics
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sam at webkit.org

To create a clear boundary and allow for more caching opportunities, we should convert the CSSValue types to have immutable value semantics, moving whatever remains to the style / style building system.

In the end, I would like to have a type for each possible top level css value, and make CSSValue itself a type-erasing wrapper of sorts:

struct CSSValue {
    std::variant<
        // Each css value type here.
    > value;
};


We can use this opportunity to create more strongly typed results coming out of the parser, so style building does not have to do quite as much type checking or assuming.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221016/44e6998f/attachment-0001.htm>