[Webkit-unassigned] [Bug 99842] Touch operation corrupts screen when specifying other than overflow:visible in css

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 16 10:32:16 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=99842

--- Comment #11 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
(In reply to Ahmad Saleem from comment #10)
> (In reply to Brent Fulgham from comment #9)
> > Comment on attachment 183879 [details]
> > The modified patch to fix buildbot warning
> > 
> > I think this patch is good, but it would be better to include test cases so
> > that we do not run into this again.  Could you look at what Terry Anderson
> > did on the Chromium port (https://chromiumcodereview.appspot.com/14767007)
> > and perhaps use the same test case?
> > 
> > Terry's change was at a lower level; perhaps we should do the same so that
> > all ports would have the desired scrolling behavior, not just the Windows
> > ports.
> 
> If we add "clamp" as third argument in this:
> 
> https://github.com/WebKit/WebKit/blob/
> 71af797599da12fa56a502b6f23501f31e289dc2/Source/WebCore/rendering/
> RenderLayerScrollableArea.cpp#L1891
> 
> and merge test cases from the Chromium patch, will it work?
> 
> Tried to change testcase from Chromium patch into JSFiddle but it seems, it
> will work only in EWS:
> 
> https://jsfiddle.net/ca3pouzy/show
> 
> Or this is not needed anymore? Thanks!

We had "clamp" and merge this patch some time in the past but this commit reverted and removed "clamp", which seems we might not need this anymore.

https://github.com/WebKit/WebKit/commit/01e728a2e5f83ce6234dae42132c7c0db7eb1f07

@Simon - this change was done by you, do you think we can close this bug now or we just land test cases from Chromium patch, if needed? Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221016/e698a203/attachment.htm>


More information about the webkit-unassigned mailing list