[Webkit-unassigned] [Bug 246454] PDFPlugin hangs in deallocation when data load contends with waiting for thread completion

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=246454

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #3 from Darin Adler <darin at apple.com> ---
The simplest fix I can think of is this inside the for loop at https://github.com/WebKit/WebKit/blob/main/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm#L879:

    if (plugin->isBeingDestroyed())
        dataSemaphore.signal();
    else {
        plugin->getResourceBytesAtPosition( ...
        ...
    }

Given both destroy and the for loop are running on the main thread, I don’t think we have to do anything more sophisticated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221014/2ad6173d/attachment.htm>