[Webkit-unassigned] [Bug 246246] [CMake] Selectively treat some warnings as errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=246246

--- Comment #4 from Adrian Perez <aperez at igalia.com> ---
OTOH, I think we may want to have these enabled:

  -Wabstract-final-clas(In reply to Michael Catanzaro from comment #2)
> I agree that incremental progress is better than no progress. That said, I
> don't think the warnings you've selected will really make any difference
> since I've never seen those warnings occur in WebKit ever. The most
> important warnings that I would start with are -Wredundant-move,
> -Wunused-variable, and -Wreturn-type.
> 
> Instead of enabling them always, I would just use them as a temporary
> implementation of DEVELOPER_MODE_FATAL_WARNINGS until we're able to really
> make everything fatal.

The two I started with are supported only by Clang, and you are most likely
to see them happen with non-unified builds. They greatly help figure out
where a FooInlines.h header is missing, which normally would cause the
linker to produce errors of varying degrees of cryptic-ness. I am slowly
adding a few more, probably to end up including the ones you also suggest.

I want the ones we add this way to be 100% non-controversial so we can
have them always on, no exceptions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221010/611608c1/attachment.htm>