[Webkit-unassigned] [Bug 110391] Document::parsing() and Document::setParsing() are non-sense and should be removed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 8 14:33:49 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=110391

Ahmad Saleem <ahmad.saleem792 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ahmad.saleem792 at gmail.com

--- Comment #2 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
We still have these:

https://github.com/WebKit/WebKit/blob/3337a23e60d4843d0ef0beda84b02115b2ca306d/Source/WebCore/dom/Document.h#L782

https://github.com/WebKit/WebKit/blob/ac4cebfbe41a934ff5d256c284c081b6ceec252b/Source/WebCore/dom/Document.cpp#L3338

void Document::setParsing(bool b)
{
    m_bParsing = b;

    if (m_bParsing && !m_sharedObjectPool)
        m_sharedObjectPool = makeUnique<DocumentSharedObjectPool>();

    if (!m_bParsing && view() && !view()->needsLayout())
        view()->fireLayoutRelatedMilestonesIfNeeded();
}

etc.

__________

Do we need to keep it or is it something we have changed and now have different purpose about this code? Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221008/626bcbcd/attachment.htm>


More information about the webkit-unassigned mailing list